Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Travis CI and a tox.ini #4

Merged
merged 24 commits into from
Jul 12, 2019
Merged

Set up Travis CI and a tox.ini #4

merged 24 commits into from
Jul 12, 2019

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Jul 11, 2019

Replace the deprecated-and-removed zope.testing.doctest with the stdlib doctest module.

Make the tests pass no matter how you run them (bin/test vs tox).

Set up Appveyor and Travis CI and Coveralls.

Fix a zdaemon compatibility problem on Windows.

Replace the deprecated-and-removed zope.testing.doctest with the stdlib
doctest module.
Because we have special Windows-only tests.
@mgedmin
Copy link
Member Author

mgedmin commented Jul 11, 2019

Ok, so if I run the tests with --pdb, I see the raw text before the renormalizer defaces it unrecognizable, and I see

Want:

sys.path[0:0] = [
  '/sample-buildout/eggs/zdaemon-2.0-py2.4.egg',
  '/sample-buildout/eggs/setuptools-0.6-py2.4.egg',
  '/sample-buildout/eggs/ZConfig-2.3-py2.4.egg',
  '/zope3recipes',
  ]

Got:

sys.path[0:0] = [
  '/home/mg/src/zopefoundation/zc.zope3recipes/.tox/py27/lib/python2.7/site-packages',
  ]

And the reason is that zdaemon, setuptools and ZConfig are already installed in the virtualenv's site-packages so buildout does not add them again.

Mystery 1: which renormalizer rule mangles /sample-buildout/eggs/ZConfig-2.3-py2.4.egg into /sample-pyN.N.egg?

Mystery 2: what to do to make the tests pass?

So that coverage report -m won't dump us about ALL THE PACKAGES EVER.
@mgedmin
Copy link
Member Author

mgedmin commented Jul 11, 2019

Mystery 1: which renormalizer rule mangles /sample-buildout/eggs/ZConfig-2.3-py2.4.egg into /sample-pyN.N.egg?

The regex that tried to drop the version number from egg pathnames.

@mgedmin
Copy link
Member Author

mgedmin commented Jul 11, 2019

I'm close to giving up on this.

@mgedmin mgedmin marked this pull request as ready for review July 12, 2019 12:58
@mgedmin
Copy link
Member Author

mgedmin commented Jul 12, 2019

Does anyone want to review this?

pywin32 is newer (version 224 instead of 223) and the name seems more
official.
@mgedmin mgedmin mentioned this pull request Jul 12, 2019
@mgedmin mgedmin merged commit a798cc0 into master Jul 12, 2019
@mgedmin mgedmin deleted the ci branch July 12, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant