Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring for buildout-recipe #25

Merged
merged 7 commits into from Mar 12, 2021
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Feb 24, 2021

All tests are failing locally – maybe because I am running them on MacOS, let's see how GHA behaves.

Update tests to run locally, and on GHA.

@icemac icemac self-assigned this Feb 24, 2021
@icemac
Copy link
Member Author

icemac commented Feb 24, 2021

Locally (MacOS) the tests fail with:

File ".../src/zdaemon/tests/tests.py", line 178, in zdaemon.tests.tests.test_kill
Failed example:
    system("./zdaemon -Cconf kill CONT")
Expected:
    kill(NNN, 18)
    signal SIGCONT sent to process NNN
Got:
    kill(NNN, 19)
    signal SIGCONT sent to process NNN



Failure in test test_logreopen (zdaemon.tests.tests)
Failed doctest test for zdaemon.tests.tests.test_logreopen
  File ".../src/zdaemon/tests/tests.py", line 192, in test_logreopen

----------------------------------------------------------------------
File ".../src/zdaemon/tests/tests.py", line 209, in zdaemon.tests.tests.test_logreopen
Failed example:
    system("./zdaemon -Cconf logreopen")
Expected:
    kill(NNN, 12)
    signal SIGUSR2 sent to process NNN
Got:
    kill(NNN, 31)
    signal SIGUSR2 sent to process NNN

Should I adapt the ReNormalizer? Is the second number actually important?

@icemac icemac requested a review from mgedmin February 24, 2021 16:46
@dataflake
Copy link
Member

@icemac The numeric representation of a signal depends on the platform you're on. So those numbers are not relevant for the test and should not be specified. There's more places where text output is expected that is tied to one specific platform.

icemac pushed a commit to zopefoundation/meta that referenced this pull request Feb 26, 2021
@icemac icemac marked this pull request as ready for review February 26, 2021 15:12
.coveragerc Show resolved Hide resolved
icemac pushed a commit to zopefoundation/meta that referenced this pull request Mar 5, 2021
@icemac icemac merged commit a55ecd2 into master Mar 12, 2021
@icemac icemac deleted the config-with-buildout-recipe branch March 12, 2021 17:01
@icemac
Copy link
Member Author

icemac commented Mar 12, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants