New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring for buildout-recipe #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally (MacOS) the tests fail with:
Should I adapt the ReNormalizer? Is the second number actually important? |
@icemac The numeric representation of a signal depends on the platform you're on. So those numbers are not relevant for the test and should not be specified. There's more places where text output is expected that is tied to one specific platform. |
Add Python 3.9 support.
icemac
pushed a commit
to zopefoundation/meta
that referenced
this pull request
Feb 26, 2021
dataflake
approved these changes
Feb 26, 2021
Thank you for reviewing this PR. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are failing locally – maybe because I am running them on MacOS, let's see how GHA behaves.Update tests to run locally, and on GHA.