Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async is a keyword in Python 3.7 #104

Closed
mgedmin opened this issue Feb 1, 2018 · 1 comment
Closed

async is a keyword in Python 3.7 #104

mgedmin opened this issue Feb 1, 2018 · 1 comment
Labels
bug

Comments

@mgedmin
Copy link
Member

mgedmin commented Feb 1, 2018 

Python 3.7.0b1+ (heads/3.7:7f38637853, Feb  1 2018, 13:09:53) 
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ZEO.ClientStorage
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/py37/lib/python3.7/site-packages/ZEO/ClientStorage.py", line 271
    self._async = self._server.async
                                   ^
SyntaxError: invalid syntax
@icemac icemac added the bug label Feb 23, 2018
jamadden added a commit that referenced this issue Mar 27, 2018
@jamadden
Fix many deprecation/resource warnings, and bump up test verbosity on…
fa4c749 
… travis

Some of the tests are being killed because we don't produce any output
when running parallel tests in a layer with -v1.

The amount of warnings made it hard to see real failures.

Also use more recent PyPy, and test on Py 3.6 (which produces the
'async' warnings we'll use to fix #104)
jamadden added a commit that referenced this issue Mar 27, 2018
@jamadden
Fix many deprecation/resource warnings, and bump up test verbosity on…
98fabd1 
… travis

Some of the tests are being killed because we don't produce any output
when running parallel tests in a layer with -v1.

The amount of warnings made it hard to see real failures.

Also use more recent PyPy, and test on Py 3.6 (which produces the
'async' warnings we'll use to fix #104)
@jamadden
Copy link
Member

The commit 52fb9d4 did not fix this issue, it just fixed some of the deprecations. There are still some uses in our own code.

@jamadden jamadden reopened this Mar 27, 2018
@jamadden jamadden mentioned this issue Mar 27, 2018
Merged
jamadden added a commit that referenced this issue Mar 27, 2018
@jamadden
Rename all 'async' to 'async_' for compatibility with Python 3.7.
6afcbb8 
Fixes #104.

I don't think any of those attributes were part of ZEO's public API.
@jamadden jamadden mentioned this issue Mar 27, 2018
Merged
jamadden added a commit that referenced this issue Mar 28, 2018
@jamadden
Rename all 'async' to 'async_' for compatibility with Python 3.7.
6693ddf 
Fixes #104.

I don't think any of those attributes were part of ZEO's public API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgedmin @icemac @jamadden