-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all 'async' to 'async_' for compatibility with Python 3.7. #110
Conversation
I can't see anything wrong with the diff, certainly not to explain the timeouts causing the test failures. |
Yeah, the timeouts have been happening for awhile (all the builds in the last six months, approx?). See #109 for a tiny bit more background. |
Fixes #104. I don't think any of those attributes were part of ZEO's public API.
Travis is using 3.4.6. I can't reproduce the failures locally with 3.4.4 or 3.6.4.
Fixing #113 got all the builds green except the ZEO_MTACCEPTOR builds. I haven't been able to reproduce the problem there yet on my mac or in a Linux VM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! (I'm getting close on the MTACCEPTOR stuff. It appears to be an IPv6 dualstack issue. The broken tests are using IPv6, the working tests use V4. I've run into issues with this on Travis with gevent.) |
Fixes #104.
I don't think any of those attributes were part of ZEO's public API.