Rename all 'async' to 'async_' for compatibility with Python 3.7. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't see anything wrong with the diff, certainly not to explain the timeouts causing the test failures. |
|
Yeah, the timeouts have been happening for awhile (all the builds in the last six months, approx?). See #109 for a tiny bit more background. |
Fixes #104. I don't think any of those attributes were part of ZEO's public API.
Travis is using 3.4.6. I can't reproduce the failures locally with 3.4.4 or 3.6.4.
|
Fixing #113 got all the builds green except the ZEO_MTACCEPTOR builds. I haven't been able to reproduce the problem there yet on my mac or in a Linux VM. |
|
Thanks! (I'm getting close on the MTACCEPTOR stuff. It appears to be an IPv6 dualstack issue. The broken tests are using IPv6, the working tests use V4. I've run into issues with this on Travis with gevent.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104.
I don't think any of those attributes were part of ZEO's public API.