Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create more wheels #32

Closed
icemac opened this issue Feb 9, 2018 · 5 comments
Closed

Create more wheels #32

icemac opened this issue Feb 9, 2018 · 5 comments
Labels
help wanted

Comments

@icemac
Copy link
Member

icemac commented Feb 9, 2018 •
edited
Loading

Currently there is only an sdist the sdist and win wheels on PyPI. Having more wheels there would be nice.
@mgedmin
Copy link
Member

mgedmin commented Feb 9, 2018

We can steal zope.interface's .travis.yml and appveyor.yml. IIRC there's nothing specific to zope.interface in there.

zopefoundation/zope.security#46 has a checklist for Windows wheels. Do you also want manylinux and/or Mac OS wheels?

@mgedmin
Copy link
Member

mgedmin commented Feb 9, 2018

Never mind; I see zodbpickle already has Windows wheels. What remains is taking manylinux bits from zope.interface's .travis.yml and perhaps generating a new secret for this repository (Travis encryption of the zope.wheelbuilder PyPI password is valid for a repository, whereas Appveyor's encryption is for a user account).

@mgedmin
Copy link
Member

mgedmin commented Feb 9, 2018

Here's the Travis secret for zodbpickle:

secure: "edbJQIhe7grjaug7dxExoyB0zkrLca5IphzuQd2IfjGjBCY6Dn+QEBtDOMOcPjUsSvgxWL2XG2ZGIFF33bsoFlq0bZFPMtv5ZQ6jcpYQEpPX61fHsNzPs2RXavpHgHFC4aXt1o7jH7aSeImV98WWsNZTL5rhW4aHbgOM/jnnWdc="

@mgedmin
Copy link
Member

mgedmin commented Feb 9, 2018

In addition to zope.interface's .travis.yml you'll want .manylinux.sh and .manylinux-install.sh, and you'll want to s/zope.interface/zodbpickle/ in the latter.

@icemac icemac changed the title Create wheels Create more wheels Feb 14, 2018
icemac pushed a commit that referenced this issue Feb 14, 2018
Create more wheels (manylinux and Mac OS).
cae31f8 
Additionally add coverage/coveralls support.
The changes are taken from zope.interface.

Fixes #32.
@icemac icemac mentioned this issue Feb 14, 2018
Merged
@icemac
Copy link
Member Author

icemac commented Feb 14, 2018

@mgedmin Thank you for your advice and sorry for being not patient enough to see the windows wheels which got created via AppVeyor.

icemac pushed a commit that referenced this issue Feb 19, 2018
Create more wheels (manylinux and Mac OS). (#33)
37d583e 
* Create more wheels (manylinux and Mac OS).

Additionally add coverage/coveralls support.
The changes are taken from zope.interface.

Fixes #32.

* Use `coverage` instead of `nosetests` for coverage.

Plus configure release process.

* Require a minimum coverage.
icemac pushed a commit that referenced this issue Feb 19, 2018
Create more wheels (manylinux and Mac OS). (#33)
3d305f9 
* Create more wheels (manylinux and Mac OS).

Additionally add coverage/coveralls support.
The changes are taken from zope.interface.

Fixes #32.

* Use `coverage` instead of `nosetests` for coverage.

Plus configure release process.

* Require a minimum coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgedmin @icemac