Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring for c-code #88

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented May 27, 2024

No description provided.

@tseaver
Copy link
Member Author

tseaver commented May 27, 2024

@dataflake, @icemac Any idea about the skipped-but-required tests here?

I could just remove them from the branch protection, but maybe there is policy for applying such changes uniformly across the organization?

@dataflake
Copy link
Member

I have fixed those manually usually. When you run the configure script there's a step at the end that does this, though.

@icemac
Copy link
Member

icemac commented May 28, 2024

I have fixed those manually usually. When you run the configure script there's a step at the end that does this, though.

Even though this script might have a bug: It should keep the setting of required code reviews for pull requests but seems to set them always. – I think we did not have a discussion for which packages (or even all) code reviews should be required.

@dataflake
Copy link
Member

IMHO the setting of "always require reviews, but these groups (owners, managers, release managers) are exempt" is good for all packages.

@tseaver tseaver merged commit 692cd83 into master May 28, 2024
58 checks passed
@tseaver tseaver deleted the config-with-c-code-template-1c0f31f5 branch May 28, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants