do not break refs to blobstorage files #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by skipping pickles for ZODB.blob.Blob objects
frisi
commented
Oct 4, 2018
src/zodbupdate/serialize.py
Outdated
| @@ -299,6 +303,10 @@ def rename(self, input_file): | |||
|
|
|||
| class_meta = self.__update_class_meta(class_meta) | |||
|
|
|||
| if class_meta in SKIP_TYPES: | |||
There was a problem hiding this comment.
using ZODB.blob.is_blob_record as suggested by @jimfulton yesterday would require to obtain input_file data (input_file.seek(0); is_blob_record(input_file.read()))
to me it seems sufficient and more performant to check for the class here as it is already available.
|
ping @rbu |
|
I am implementing it. Your solution is not enough, there's many formats for the |
|
This should do the trick. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by skipping pickles for ZODB.blob.Blob objects in the rename/convert method blobs do not get broken when running
zodbupdate --pack --convert-py3 --file Data.fsas the record's oid stays the same, and also the old serial should be used when saving it back (see https://github.com/zopefoundation/zodbupdate/blob/1.0/src/zodbupdate/update.py#L84) i don't see why we need to skip them here at all.
i need some help with the test
test_blob_pickles_are_left_untouched:module1.Factorydoes not work as the class_meta ispersistent.mapping.PersistentMappinginstead ofmodule1.Factory