Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7, 3.8 and 3.9. #4

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 19, 2020

Drop support for Python 3.3 and 3.4.
Lint the code.
Switch CI to GHA.

Fixes #3.

@icemac
Copy link
Member Author

icemac commented Dec 19, 2020

The drop in coverage seems to result from switching to branch coverage instead of line coverage which was used before.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor suggestions.

src/zope/app/authentication/browser/rolepermissionview.py Outdated Show resolved Hide resolved
src/zope/app/authentication/browser/schemasearch.py Outdated Show resolved Hide resolved
src/zope/app/authentication/browser/tests/test_doctests.py Outdated Show resolved Hide resolved
src/zope/app/authentication/browser/tests/test_doctests.py Outdated Show resolved Hide resolved
@icemac icemac merged commit 89fba02 into master Jan 13, 2021
@icemac icemac deleted the config-with-pure-python branch January 13, 2021 07:35
@icemac
Copy link
Member Author

icemac commented Jan 13, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DeprecationWarnings
3 participants