Skip to content

Commit

Permalink
Use zapi.isinstance() as appropriate.
Browse files Browse the repository at this point in the history
Always use zapi.isinstance(o) instead of isinstance(removeSecurityProxy(o))
when the unproxied object is not otherwise needed.
  • Loading branch information
freddrake committed Sep 1, 2004
1 parent 2ffbcb6 commit fada478
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions browser/tests/test_directoryresource.py
Expand Up @@ -99,14 +99,13 @@ def testCorrectFactories(self):
resource = DirectoryResourceFactory(path, checker, 'files')(request)

image = resource['test.gif']
self.assert_(isinstance(removeSecurityProxy(image), FileResource))
self.assert_(zapi.isinstance(image, FileResource))
template = resource['test.pt']
self.assert_(isinstance(removeSecurityProxy(template),
PageTemplateResource))
self.assert_(zapi.isinstance(template, PageTemplateResource))
file = resource['test.txt']
self.assert_(isinstance(removeSecurityProxy(file), FileResource))
self.assert_(zapi.isinstance(file, FileResource))
file = resource['png']
self.assert_(isinstance(removeSecurityProxy(file), FileResource))
self.assert_(zapi.isinstance(file, FileResource))

def test_suite():
return makeSuite(Test)
Expand Down

0 comments on commit fada478

Please sign in to comment.