Add support for PyPy #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5 Also directly use zope-testrunner instead of redirecting through tox.ini on travis. This lets us use travis caching for much faster test runs.
|
Changes Unknown when pulling ab3748a on pypy into ** on master**. |
icemac
approved these changes
Dec 21, 2016
| @@ -143,7 +143,7 @@ example: | |||
| >>> import os, tempfile | |||
| >>> temp_dir = tempfile.mkdtemp() | |||
| >>> sitezcml = os.path.join(temp_dir, 'site.zcml') | |||
| >>> written = open(sitezcml, 'w').write('<configure />') | |||
| >>> with open(sitezcml, 'w') as f: _ = f.write('<configure />') | |||
There was a problem hiding this comment.
It would be easier to read when breaking this to two lines. Maybe a function could hide the implementation details of writing to the temporary file.
|
Changes Unknown when pulling c6f0108 on pypy into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Also directly use zope-testrunner instead of redirecting through tox.ini
on travis. This lets us use travis caching for much faster test runs.
Also enable coverage reporting.