Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Py36, Drop Py33, restore tests for zope.component 4.4 #3

Merged
merged 3 commits into from
Aug 2, 2017
Merged

Add Py36, Drop Py33, restore tests for zope.component 4.4 #3

merged 3 commits into from
Aug 2, 2017

Conversation

jamadden
Copy link
Member

  • Badges
  • 100% coverage
  • Enable coveralls
  • Whitespace and import cleanup

@jamadden jamadden mentioned this pull request Jul 28, 2017
Merged
@jamadden jamadden requested a review from mgedmin July 31, 2017 13:00
@tseaver tseaver mentioned this pull request Jul 31, 2017
Closed
4 tasks
icemac
icemac approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jamadden jamadden merged commit 1f7326a into master Aug 2, 2017
@jamadden jamadden deleted the py36 branch August 2, 2017 11:15
@jamadden
Copy link
Member Author

jamadden commented Aug 2, 2017

Thanks!

Can we please get a PyPI release when convenient, @tseaver? (Or access.)

@tseaver
Copy link
Member

tseaver commented Aug 2, 2017

jamadden added as an owner on PyPI.

@jamadden
Copy link
Member Author

jamadden commented Aug 2, 2017

Thank you. It's not showing up that I have access, though.

@tseaver
Copy link
Member

tseaver commented Aug 2, 2017

Ugh, must've added you to some other project via tab completion / muscle memory. I just did it for zope.browser{page,menu,resource}

@jamadden
Copy link
Member Author

jamadden commented Aug 2, 2017

Thanks again. I've pushed zope.browserpage 4.2.0 to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

@mgedmin mgedmin Awaiting requested review from mgedmin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamadden @tseaver @icemac