Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 #4

Merged
merged 1 commit into from Oct 5, 2018
Merged

Add support for Python 3.7 #4

merged 1 commit into from Oct 5, 2018

Conversation

vernans
Copy link
Contributor

@vernans vernans commented Oct 5, 2018

No description provided.

@vernans vernans requested a review from icemac October 5, 2018 11:36
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -56,9 +56,10 @@ def alltests():
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. I see the last release claimed to remove support, but the 3.3 classifier got left behind and the 3.6 classifier wasn't added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a terrible Python script to verify the consistency of classifiers, travis.yml, tox.ini, appveyor.yml and manylinux build shell scripts: https://github.com/mgedmin/scripts/blob/master/check-python-versions

Maybe it could be cleaned up and hooked up to Travis CI?

@icemac icemac merged commit b6bc96e into master Oct 5, 2018
@icemac icemac deleted the Python3.7support branch October 5, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants