Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test on Python 3.7 #10

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Fix failing test on Python 3.7 #10

merged 2 commits into from
Dec 8, 2017

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Dec 7, 2017

@mgedmin mgedmin requested a review from icemac December 7, 2017 19:57
jamadden
jamadden approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

icemac
icemac approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mgedmin mgedmin merged commit 21ff495 into master Dec 8, 2017
@mgedmin mgedmin deleted the fix-python3.7 branch December 8, 2017 08:18
icemac pushed a commit that referenced this pull request Dec 9, 2017
Add change log entry for #10
d83b895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

@jamadden jamadden jamadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgedmin @icemac @jamadden