Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox and Travis by using zope.testrunner #27

Merged
merged 3 commits into from Jun 29, 2017
Merged

Fix tox and Travis by using zope.testrunner #27

merged 3 commits into from Jun 29, 2017

Conversation

jamadden
Copy link
Member

DRY with regards to dependencies. This lets us simplify travis to not use Tox which in turn lets us easily enable coveralls.

Add Python 3.6, drop Python 3.3. Drop support for 'setup.py test.'

Fixes #26

Are the PURE_PYTHON builds actually necessary? We are testing PyPy which is pure-python automatically.

DRY with regards to dependencies. This lets us simplify travis to not
use Tox which in turn lets us easily enable coveralls.

Fixes #26
@jamadden
Copy link
Member Author

Are the PURE_PYTHON builds actually necessary?

Since we're publishing manylinux wheels now, pip will install those. The PURE_PYTHON variable is not helpful for either Travis or Tox anymore.

We publish manylinux wheels now and pip will install those. (The same
is probably true for tox, but the end user may be able to control that
better so I'm leaving those environments for now.)

We test PyPy so we do cover the pure environments.
- pip install -U pip setuptools
- pip install -U coveralls coverage
- if [[ -n "$MINIMAL" ]]; then pip install -U -e ".[mintests]"; fi
- if [[ -z "$MINIMAL" ]]; then pip install -U -e ".[test,docs]"; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to be installing Sphinx in all the environments, do we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to do a subsequent PR that gets the doctests running in Python 3 and turn them on by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#28

tox.ini Outdated
@@ -2,42 +2,29 @@
envlist =
# Jython support pending 2.7 support, due 2012-07-15 or so. See:
# http://fwierzbicki.blogspot.com/2012/03/adconion-to-fund-jython-27.html
py27,py27-minimal,py27-pure,pypy,py33,py34,py34-pure,py35,py35-pure,pypy3,coverage,docs
py27,py27-minimal,py27-pure,pypy,py33,py34,py34-pure,py35,py35-pure,py36,pypy3,coverage,docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be droppring the -pure variants here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated about that. They're not useful by default, but someone could configure their pip in such a way as to make them useful. So maybe leave the configurations but take them out of the envlist? (Oh, that's exactly what you're suggesting, isn't it?)

@jamadden
Copy link
Member Author

jamadden commented Jun 29, 2017

Travis builds are backed up this morning due to an issue, but the previous build of this PR did complete.

I also would like to plan a subsequent PR to get coverage back up to 100%---nose ignores more things by default than plain coverage does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants