Do not allow empty identifiers in PythonIdentifier.

This restores the previous behaviour of validate(); fromUnicode() previously did no validation at all.
zopefoundation · Sep 24, 2018 · d315d89 · d315d89
1 parent 36677d1
commit d315d89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/docs/api/fields.rst b/docs/api/fields.rst
@@ -43,7 +43,7 @@
       Validation Error '3foo'
       Validation Error 'foo:'
       Validation Error '\\'
-      ''
+      Validation Error ''
 
 .. autoclass:: GlobalObject
    :members:

diff --git a/src/zope/configuration/fields.py b/src/zope/configuration/fields.py
@@ -35,9 +35,14 @@
 
 class PythonIdentifier(schema_PythonIdentifier):
     """
-    This class is deprecated, prefer `zope.schema.PythonIdentifier`.
+    This class is like `zope.schema.PythonIdentifier`, but does not allow empty strings.
     """
 
+    def _validate(self, value):
+        super(PythonIdentifier, self)._validate(value)
+        if not value:
+            raise ValidationError(value).with_field_and_value(self, value)
+
 
 @implementer(IFromUnicode)
 class GlobalObject(Field):