Update the handling of PURE_PYTHON to match zope.interface and persistest #35
Conversation
…tent Also stop using the deprecated, untested, ``zope.interafce.declarations.ObjectSpecification`` function in favor of ``Provides``.
Also other minor doc improvements.
| 'zope.testing', | ||
| 'zope.testrunner', | ||
| ], | ||
| tests_require=extras['test'], |
There was a problem hiding this comment.
Weren't we dropping setup.py test everywhere? test_require is not useful for anything else.
| @@ -26,7 +26,7 @@ commands = | |||
| coverage report --fail-under=100 --show-missing | |||
| # parallel mode: make sure all builds complete before we run this one | |||
| depends = | |||
| py27,py35,py36,py37,py38,pypy,py27-zodb,pypy-zodb,py27-pure-zodb | |||
| py27,py35,py36,py37,py38,pypy,pypy3 | |||
There was a problem hiding this comment.
py27-pure should remain in here I think
There was a problem hiding this comment.
Does it add much value given the existence of pypy and pypy3?
There was a problem hiding this comment.
(Note that it's still in the environment list, just not the parallel coverage dependency list.)
There was a problem hiding this comment.
I dunno, do we want to run coverage combine while coverage run -p is still running on py27-pure?
I suppose pypy will cover the pure-Python alternative branches so the coverage number shouldn't drop because of this. As long as we don't have pypy-specific vs Python-pure-specific branches in the code...
There was a problem hiding this comment.
I suppose pypy will cover the pure-Python alternative branches so the coverage number shouldn't drop because of this.
It didn't, so...
As long as we don't have pypy-specific vs Python-pure-specific branches in the code…
...I don't think we do. If we do in the future, the coverage number will drop and we can know we need to depend on it or rework the code.
|
The merge was maybe a little bit premature? |
|
I apologize, I didn't realize you were reviewing again. |
Or maybe not. |
I'm sorry, I'm unpredictable that way. There are days when I tire of banging head against unsolvable problems (Selenium test flakyness, to pick a random example) in $DAYJOB and I poll GitHub notifications for any distraction. And there are days (weeks) when I can't find the energy to review things I've been asked to review... |
|
Some of my Selenium frustration may have leaked through, for which I apologize. |
|
No worries! Thank you for all you do here. |
Specifically, we can always build the extensions, so build-time handling on PURE_PYTHON is gone. Runtime is updated to respect PURE_PYTHON=0. Tests are added for this.
zope.interafce.declarations.ObjectSpecificationfunction in favor ofProvides.setup.py testpython_requiresmetadataThe branch name is issue34 because this started as some cleanups while working on #34, but it grew big enough to require its own PR.