Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.6 and Drop Python 3.3 #3

Merged
merged 3 commits into from
Aug 8, 2017
Merged

Add Python 3.6 and Drop Python 3.3 #3

merged 3 commits into from
Aug 8, 2017

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Aug 2, 2017

  • Badges
  • Enable coveralls and add a coverage environment
    • 100% coverage
  • Rename a .txt to .rst.

@jamadden
Add Python 3.6 and Drop Python 3.3
e2bb3b5 
- Badges
- Enable coveralls and add a coverage environment
  - 100% coverage
- Rename a .txt to .rst.
@tseaver tseaver mentioned this pull request Aug 2, 2017
Closed
4 tasks
icemac
icemac approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and LGTM.

setup.py Outdated
'zope.tales',
],
include_package_data=True,
tests_require=['zope.testing', 'zope.browserpage'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to deduplicate the test dependencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just lazy I guess. Done.

tox.ini Outdated
@@ -1,20 +1,21 @@
[tox]
envlist =
py27,py33,py34,py35,pypy,pypy3
py27,py34,py35,py36,pypy,pypy3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here about the coverage environment as in zopefoundation/zope.site#7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@icemac
Copy link
Member

icemac commented Aug 8, 2017

BTM I made you an owner of this package on PyPI.

@jamadden jamadden merged commit e3b25b6 into master Aug 8, 2017
@jamadden jamadden deleted the py36 branch August 8, 2017 11:18
@jamadden
Copy link
Member Author

jamadden commented Aug 8, 2017

Thanks. I've released 4.1.0 to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamadden @icemac