Add support for Python 3.6 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9 Also update to current tox.ini and .travis.yml to enable coverage.
tseaver
reviewed
Jun 27, 2017
| @@ -1 +1 @@ | |||
| __import__('pkg_resources').declare_namespace(__name__) | |||
| __import__('pkg_resources').declare_namespace(__name__) # pragma: no cover | |||
There was a problem hiding this comment.
That one is odd: I'm guessing it gets skipped entirely by the namespace machinery, but then why does coverage pick it up at all?
There was a problem hiding this comment.
I'm guessing it gets skipped entirely by the namespace machinery
Right, as far as imports go.
why does coverage pick it up at all?
Because the report phase is based on the files it finds on disk, I'm assuming. It's the same for any module that's not imported at all but is still on disk.
src/zope/deprecation/tests.py
Outdated
| def _makeOne(self, msg, *args): | ||
| cls = self._getTargetClass() | ||
| return cls(msg, *args) | ||
|
|
||
| def fixture(self): | ||
| return 'fixture' | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
I think this method could just be removed altogether.
There was a problem hiding this comment.
Or we could (did) add a test case that calls it :)
tseaver
approved these changes
Jun 27, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Also update to current tox.ini and .travis.yml to enable coverage.