Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for running the tests using python setup.py test. #6

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Drop support for running the tests using python setup.py test. #6

merged 3 commits into from
Oct 9, 2020

Conversation

icemac
Copy link
Member

@icemac icemac commented Oct 2, 2020

No description provided.

@icemac icemac self-assigned this Oct 2, 2020
mgedmin
mgedmin approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and good riddance!

We probably should drop Python 3.4 support and bump pypy version in .travis.yml first.

@icemac
Copy link
Member Author

icemac commented Oct 2, 2020

#8 will remove Python 3.4 support.

@icemac icemac merged commit cc0cd5c into master Oct 9, 2020
@icemac icemac deleted the drop-setup.py-test branch October 9, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees

@icemac icemac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemac @mgedmin