Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.6 and coveralls #7

Merged
merged 2 commits into from Jun 26, 2017
Merged

Add Python 3.6 and coveralls #7

merged 2 commits into from Jun 26, 2017

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Jun 23, 2017

Drop python 3.3.

Minor misc project gardening.

Fixes #6

@tseaver
Copy link
Member

tseaver commented Jun 25, 2017

In "days of yore", we avoided adding deps in the "bottom-most" ZTK packages (zope.event, zope.interface, zope.component, etc.) to stuff like zope.testrunner / zope.testing because they did indeed depend on one or more of them. If they no longer do so, then this should be fine.

@jamadden
Copy link
Member Author

That completely makes sense to me! Circular dependencies are a special kind of torment, even in teat code. I worked hard to remove them recently in a lot of zope.app and other packages. I did a cursory check for the packages involved here and didn’t find anything (nothing low level depends on zope.event). I can look into presenting a more precise dependency graph.

@jamadden
Copy link
Member Author

Here's what pipdeptree says:

zope.event==4.2.1.dev0
  - setuptools [required: Any, installed: 36.0.1]
zope.testing==4.6.2
  - setuptools [required: Any, installed: 36.0.1]
zope.testrunner==4.7.0
  - setuptools [required: Any, installed: 36.0.1]
  - six [required: Any, installed: 1.10.0]
  - zope.exceptions [required: Any, installed: 4.1.0]
    - setuptools [required: Any, installed: 36.0.1]
    - zope.interface [required: Any, installed: 4.4.2]
      - setuptools [required: Any, installed: 36.0.1]
  - zope.interface [required: Any, installed: 4.4.2]
    - setuptools [required: Any, installed: 36.0.1]

So it looks like we're clear.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamadden jamadden merged commit c8110ad into master Jun 26, 2017
@jamadden jamadden deleted the issue6 branch June 26, 2017 11:20
@jamadden
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants