You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
This was part of a mass update of packages in Plone. When 3.7 was in the classifiers I added 3.8 as well: Plone 5.2 and 6.0 are also tested on 3.8.
I tried restricting the mass update to only core Plone packages, but this one slipped through.
I will have a look now and am running tox locally.
Ah, finished and it works with 3.8. I will make a PR.
49f4d50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not tested neither via tox.ini nor on TravisCI. Could you please update there, too?
49f4d50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was part of a mass update of packages in Plone. When 3.7 was in the classifiers I added 3.8 as well: Plone 5.2 and 6.0 are also tested on 3.8.
I tried restricting the mass update to only core Plone packages, but this one slipped through.
I will have a look now and am running tox locally.
Ah, finished and it works with 3.8. I will make a PR.