Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest c-code template #25

Merged
merged 3 commits into from Sep 13, 2022
Merged

Update to the latest c-code template #25

merged 3 commits into from Sep 13, 2022

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Sep 12, 2022

Add a regression test for CFLAGS not having -Ofast, which is known to break things. See zopefoundation/meta#155 for reference.

Add a regression test for CFLAGS not having -Ofast, which is known to
break things.  See zopefoundation/meta#155 for
reference.
@mgedmin
Copy link
Member Author

mgedmin commented Sep 12, 2022

GitHub Actions were disabled due to inactivity. Once enabled they don't actually run for PRs opened while they were disabled, great design there, GitHub! Full marks.

Well, gift horses and all, anyway. I triggered a manual build on this branch, saw three jobs fail, wiped all the build caches, retried, all jobs succeeded: https://github.com/zopefoundation/zope.hookable/actions/runs/3038824035

@mgedmin mgedmin requested a review from icemac September 12, 2022 16:41
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac enabled auto-merge (squash) September 13, 2022 06:19
@icemac icemac merged commit 3742c38 into master Sep 13, 2022
@icemac icemac deleted the config-with-c-code branch September 13, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants