Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not extend CleanUp. #32

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Do not extend CleanUp. #32

merged 1 commit into from
Dec 19, 2017

Conversation

jamadden
Copy link
Member

Fixes #30. Fixes #31.

mgedmin
mgedmin approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamadden jamadden mentioned this pull request Dec 19, 2017
Closed
icemac
icemac approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the Cleanup base class does not seem be necessary.

@jamadden jamadden merged commit c595e7f into master Dec 19, 2017
@jamadden jamadden deleted the issue30 branch December 19, 2017 15:19
@jamadden
Copy link
Member Author

I've released 4.3.1 to PyPI. Thanks for the rapid reviews.

@icemac
Copy link
Member

icemac commented Dec 19, 2017

@jamadden Thank you for fixing this issue instantly. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamadden @icemac @mgedmin