-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.6 compatibility #8
Comments
Test log consists of many (11) repetitions of this error:
|
The offending code line is: WORDS = re.compile(r"(?L)\w+")
GLOBS = re.compile(r"(?L)\w+[\w*?]*") Now I don't know whether this regex is intended to handle Unicode or byte strings (and also whether that changes depending on which Python version you use), so I don't know whether the correct thing to do is to remove the |
The interface documentation uses the word "text" and "text" is the name of the package. Typically in zope packages that means unicode strings. However, the test case simply passes native strings---bytes on Py2, text/unicode on Py3. The tests do change the locale and assert that things happen...BUT, the docs for re.LOCALE state that (emphasis mine):
So I suspect that on Python 3, we don't want the |
Only pass re.LOCALE under Python 2. Fixes #8
Only pass re.LOCALE under Python 2. Fixes #8
This package is not yet compatible with Python 3.6, see https://travis-ci.org/zopefoundation/zopetoolkit/jobs/173487024#1333
The text was updated successfully, but these errors were encountered: