Skip to content

Commit

Permalink
Another comment update, referencing #163
Browse files Browse the repository at this point in the history
  • Loading branch information
jamadden committed Mar 19, 2020
1 parent 42c5ad2 commit 04152ae
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/zope/interface/interface.py
Expand Up @@ -276,8 +276,13 @@ def __call__(self, obj, alternate=_marker):
"""
try:
conform = getattr(obj, '__conform__', None)
# XXX: Do we really want to catch BaseException? Shouldn't
# things like MemoryError, KeyboardInterrupt, etc, get through?
# XXX: Ideally, we don't want to catch BaseException. Things
# like MemoryError, KeyboardInterrupt, and other BaseExceptions should
# get through. Here, and everywhere we have bare ``except:`` clauses.
# The bare ``except:`` clauses exist for compatibility with the C code in
# ``_zope_interface_coptimizations.c`` (``ib_call()`` in this case). Both
# implementations would need to change. But beware of things like proxies and
# Acquisition wrappers. See https://github.com/zopefoundation/zope.interface/issues/163
except: # pylint:disable=bare-except
conform = None
if conform is not None:
Expand Down

0 comments on commit 04152ae

Please sign in to comment.