100% branch coverage for 'zope.interface.declarations'.

zopefoundation · Dec 8, 2014 · b12b0bf · b12b0bf
1 parent d5a3d15
commit b12b0bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/zope/interface/declarations.py b/src/zope/interface/declarations.py
@@ -103,9 +103,8 @@ def __add__(self, other):
         seen = {}
         result = []
         for i in self.interfaces():
-            if i not in seen:
-                seen[i] = 1
-                result.append(i)
+            seen[i] = 1
+            result.append(i)
         for i in other.interfaces():
             if i not in seen:
                 seen[i] = 1

diff --git a/src/zope/interface/tests/test_declarations.py b/src/zope/interface/tests/test_declarations.py
@@ -509,13 +509,15 @@ def test_w_existing_Implements_w_bases(self):
         from zope.interface.interface import InterfaceClass
         IFoo = InterfaceClass('IFoo')
         IBar = InterfaceClass('IBar')
-        IBaz = InterfaceClass('IBar')
+        IBaz = InterfaceClass('IBaz', IFoo)
         b_impl = Implements(IBaz)
         impl = Implements(IFoo)
         impl.declared = (IFoo,)
-        class Base(object):
+        class Base1(object):
             __implemented__ = b_impl
-        class Foo(Base):
+        class Base2(object):
+            __implemented__ = b_impl
+        class Foo(Base1, Base2):
             __implemented__ = impl
         impl.inherit = Foo
         self._callFUT(Foo, IBar)