C optimizations

[bloodbare]

When we are loading zope.interface on our projects the coptimizations are not loaded saying:

ImportError: No module named '_zope_interface_coptimizations'

If we change the import to zope.interface._zope_interface_coptimizations it works.

Python 3.5

[jinty]

I made a branch for this, unfortunately a lot of tests fail with:

SystemError: Bad call flags in PyCFunction_Call. METH_OLDARGS is no longer supported!

when the optimizations are actually loaded

[tseaver]

@jinty the bug you are seeing is described here. The following patch fixes it:

--- a/src/zope/interface/_zope_interface_coptimizations.c
+++ b/src/zope/interface/_zope_interface_coptimizations.c
@@ -25,6 +25,15 @@
 #define Py_TYPE(o) ((o)->ob_type)
 #endif

+#if PY_MAJOR_VERSION >= 3
+#define PY3K
+#endif
+
+#ifdef PY3K
+/* See http://bugs.python.org/issue15657 */
+#define METH_KEYWORDS 0x0003
+#endif
+
 static PyObject *str__dict__, *str__implemented__, *strextends;
 static PyObject *BuiltinImplementationSpecifications, *str__provides__;
 static PyObject *str__class__, *str__providedBy__;

BTW, I think we should be using absolute, rather than relative, imports.

[bloodbare]

Agree on having absolute imports.

[jinty]

@tseaver thanks for carrying this on. I've deleted my branch.

I'm curious, why the preference for absolute imports?

On Tue, Nov 15, 2016 at 08:54:30AM -0800, Tres Seaver wrote:

@jinty the bug you are seeing is described here. The following patch fixes it:

--- a/src/zope/interface/_zope_interface_coptimizations.c
+++ b/src/zope/interface/_zope_interface_coptimizations.c
@@ -25,6 +25,15 @@
 #define Py_TYPE(o) ((o)->ob_type)
 #endif

+#if PY_MAJOR_VERSION >= 3
+#define PY3K
+#endif
+
+#ifdef PY3K
+/* See http://bugs.python.org/issue15657 */
+#define METH_KEYWORDS 0x0003
+#endif
+
 static PyObject *str__dict__, *str__implemented__, *strextends;
 static PyObject *BuiltinImplementationSpecifications, *str__provides__;
 static PyObject *str__class__, *str__providedBy__;

BTW, I think we should be using absolute, rather than relative, imports.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#60 (comment)

Brian Sutherland

[bloodbare]

@tseaver can we have a release with this solution ?

[tseaver]

@bloodbare 4.3.3 released.