Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.4 #143

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Drop support for Python 3.4 #143

merged 2 commits into from
Aug 20, 2019

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Aug 17, 2019

No description provided.

@mgedmin
Copy link
Member Author

mgedmin commented Aug 18, 2019

The coverage reports are rather baffling:
Ekrano nuotrauka iš 2019-08-18 17-56-14

"This comment and following blank line do not have test coverage" yes? Really?

How can you miss a branch when you're applying a decorator on a class?
Ekrano nuotrauka iš 2019-08-18 17-58-03

BTW I had some problems using tox -p auto before I started passing
--parallel-safe-build.  I'm not sure why that isn't on by default.
@mgedmin
Copy link
Member Author

mgedmin commented Aug 18, 2019

Local testing with tox -p auto --parallel--safe-build claims coverage is 100% and branch coverage is also 100%.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The missing branch coverage of the decorators seems weird. Maybe we could omit these lines from coverage at least for now.

@mgedmin mgedmin merged commit d603267 into master Aug 20, 2019
@mgedmin mgedmin deleted the drop-py34 branch August 20, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants