Always build manylinux wheels #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes it so we _always_ build manylinux wheels, but only upload them for git tags. Highlights: - Move regular Linux Python builds outside the build matrix, for conciseness. - Switch manylinux1 builds to manylinux2010 (they should still get the manylinux1 tag if they're compatible, but they'll be built with a more modern compiler toolchain). - Move twine upload from .manylinux.sh into .travis.yml's after_success, right next to the twine upload used for Mac OS builds. - This means we can't short-circuit the builds with 'exit 0' in before_install:, so overwrite the install: and script: sections too. - Move the 'docker pull' from .manylinux.sh into the install: section so it's not empty. - Provide twine credentials via environment variables instead of command-line/pypirc file. - Put related commands inside a single multiline if statement. - Use setup.py -q test (quiet build) instead of setup.py test -q (which does nothing at all AFAICT). This mirrors changes made to other zopefoundation packages tracked in zopefoundation/meta#11.
14 tasks
cjwatson
approved these changes
Nov 11, 2019
mgedmin
commented
Nov 11, 2019
| if [[ $TRAVIS_TAG && "$TRAVIS_OS_NAME" == "osx" ]]; then | ||
| # macpython 3.5 doesn't support recent TLS protocols which causes twine | ||
| # upload to fail, so we use the system Python to run twine | ||
| /usr/bin/python -m pip install twine |
There was a problem hiding this comment.
Oops I messed this up: https://travis-ci.org/zopefoundation/zope.interface/builds/610352389
/usr/bin/python: No module named pip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so we always build manylinux wheels, but only upload
them for git tags.
Highlights:
Move regular Linux Python builds outside the build matrix, for
conciseness.
Switch manylinux1 builds to manylinux2010 (they should still get the
manylinux1 tag if they're compatible, but they'll be built with a more
modern compiler toolchain).
Move twine upload from .manylinux.sh into .travis.yml's after_success,
right next to the twine upload used for Mac OS builds.
This means we can't short-circuit the builds with 'exit 0' in
before_install:, so overwrite the install: and script: sections too.
Move the 'docker pull' from .manylinux.sh into the install: section
so it's not empty.
Provide twine credentials via environment variables instead of
command-line/pypirc file.
Put related commands inside a single multiline if statement.
Use setup.py -q test (quiet build) instead of setup.py test -q (which
does nothing at all AFAICT).
This mirrors changes made to other zopefoundation packages tracked in
zopefoundation/meta#11.