Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the singleton _empty immutable. #160

Merged
merged 2 commits into from Jan 27, 2020
Merged

Make the singleton _empty immutable. #160

merged 2 commits into from Jan 27, 2020

Conversation

jamadden
Copy link
Member

Fixes #158

jensens
jensens approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jensens jensens left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering (see code review part) why we want to set empty bases on the singleton (even if it changes nothing)

src/zope/interface/declarations.py Outdated Show resolved Hide resolved
@jamadden jamadden merged commit 4912692 into master Jan 27, 2020
@jamadden jamadden deleted the issue158 branch January 27, 2020 22:56
@jamadden jamadden added this to the 5.0 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

_empty singleton is mutable
2 participants
@jamadden @jensens