Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verifyObject/Class collect and raise all errors instead of only the first #174

Merged
merged 4 commits into from Feb 10, 2020
Merged

Make verifyObject/Class collect and raise all errors instead of only the first #174

merged 4 commits into from Feb 10, 2020

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Feb 8, 2020

Fixes #171.

mgedmin
mgedmin approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/zope/interface/exceptions.py Outdated Show resolved Hide resolved
src/zope/interface/exceptions.py Outdated Show resolved Hide resolved
src/zope/interface/exceptions.py Outdated Show resolved Hide resolved
@jamadden
Simplify the string formatting rules for the Invalid exceptions.
e53e797 
As per review.

Also include the actual failing implementation object in the BrokenMethodImplementation to make it easier to track down what's going on when inheritance is involved.
@jamadden
Copy link
Member Author

jamadden commented Feb 10, 2020 •
edited

Both macOS Python 2.7 builds were broken this time. I don't think it's anything we did, I think it's the release of virtualenv 20.0.0. At least, that's the first thing I notice comparing a failed build with the last successful build. It could also be some change in the terryfy stuff.

@jamadden jamadden merged commit 447121d into master Feb 10, 2020
@jamadden jamadden deleted the issue171 branch February 10, 2020 15:46
@jamadden jamadden added this to the 5.0 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

verify[Object|Class] should report all errors found
2 participants
@jamadden @mgedmin