Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for #6. #176

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Add test case for #6. #176

merged 1 commit into from
Feb 16, 2020

Conversation

jamadden
Copy link
Member

It seems to be working now, so this fixes #6

I tried to reproduce the example by hand in Python 3.8 and 2.7 and couldn't. I don't know what I saw when I commented earlier that it was failing with the C accelerators.

It seems to be working now, so this fixes #6
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a short note to the changelog, but since its tests only it might not be needed?

@jamadden
Copy link
Member Author

Yeah, I was thinking since it's tests only it didn't really need a note.

@jamadden jamadden merged commit 0e32e11 into master Feb 16, 2020
@jamadden jamadden deleted the issue6 branch February 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignment to __class__ is broken
2 participants