Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repr of "Attribute" to look like before #177

Merged
merged 1 commit into from Feb 16, 2020
Merged

Conversation

jensens
Copy link
Member

@jensens jensens commented Feb 15, 2020

and as usual in Python.

It broke tons of tests in Plone and related. Also the repr looks like it's usual in Python.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, left out the 'object'. Thanks.

Maybe the change note could be a bit more descriptive? I was afraid everything helpful about the repr changes had been reverted.

Actually, maybe it doesn't even need a change note, since it's a slight tweak to a change introduced for this same release (that's not yet published).

@jensens
Copy link
Member Author

jensens commented Feb 16, 2020

indeed, I'll remove the note at all, as it is a fix for the newly introduced change.

@jensens jensens merged commit 7f6f60e into master Feb 16, 2020
@jensens jensens deleted the fix-signature branch February 16, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants