Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Interface.getTaggedValue follow the __iro__. #191

Merged
merged 2 commits into from Mar 18, 2020
Merged

Conversation

jamadden
Copy link
Member

Previously it manually walked up bases, meaning the answers could be inconsistent.

Fixes #190.

Also fixes several minor issues in the documentation, mostly cross-reference related.

Previously it manually walked up __bases__, meaning the answers could be inconsistent.

Fixes #190.

Also fixes several minor issues in the documentation, mostly cross-reference related.
@jamadden jamadden added this to the 5.0 milestone Mar 18, 2020
Mostly formatting. Some interfaces were being documented as clasess, which doesn't work.
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

..
IElement defines __doc__ to be an Attribute, so the docstring
in the class isn't used._

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, what a nice corner case!

@jamadden jamadden merged commit 0f80d05 into master Mar 18, 2020
@jamadden jamadden deleted the issue190 branch March 18, 2020 16:55
@jamadden
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface.get/queryTaggedValue should respect __iro__, not just __bases__
2 participants