Make Declaration.__add__ try harder to produce consistent resolution orders #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orders. By moving things from the RHS to the front of the list if they already extend something from the LHS. Fixes #193
|
GitHub actions was having some issues with its Mac runners this morning, but they seem to be resolved and this PR is now green. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving things from the RHS to the front of the list if they already extend something from the LHS.
Fixes #193
The changes in the documentation are a good example of the kind of weird things that used to happen but which should now make more sense. Previously, you could get
IRoot2ahead ofIDerived2, which is inconsistent.I'm not 100% positive this covers all possible cases (deeply nested hierarchies, branching at weird places) but it does fix the easy/common ones that I've seen in the real world. It can be improved as needed given further examples.