Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get 'tox -e lint' woking again #304

Merged
merged 2 commits into from
May 26, 2024
Merged

Get 'tox -e lint' woking again #304

merged 2 commits into from
May 26, 2024

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented May 26, 2024

Closes #303.

We should *really* kick pylint to the door:  it's comment markers
are a huge source of churn, including inducing line-too-long errors.
@tseaver tseaver requested review from icemac and dataflake May 26, 2024 05:19
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this is using pylint at all instead of flake8.

@tseaver
Copy link
Member Author

tseaver commented May 26, 2024

@dataflake

I wonder why this is using pylint at all instead of flake8.

  • For the config comments in the code, I reckon it is what @jimfulton calls "hysterical raisins."
  • The GHA config that has installs but then disables a pylint check seems to be down to the c-code config in the meta repositories:
$ grep -l pylint zope.*/.github/workflows/tests.yml 
zope.container/.github/workflows/tests.yml
zope.hookable/.github/workflows/tests.yml
zope.i18nmessageid/.github/workflows/tests.yml
zope.index/.github/workflows/tests.yml
zope.interface/.github/workflows/tests.yml
zope.proxy/.github/workflows/tests.yml
zope.security/.github/workflows/tests.yml

I'd be in favor of ripping out all of the config comments mentioning pylint. I'd really prefer as well that we get the meta config updated to actually run isort and flake8 in the same way that tox.ini runs them.

@tseaver
Copy link
Member Author

tseaver commented May 26, 2024

Another comment, especiialy after digging through the tests to get flake8 happy last night: the overall quality of the tests varies a lot, and the amount of mindless boilerplate in some of them is a bit shocking: my twenty-year older self doesn't appreciate the lack of factoring out fixtures, etc., at all, and even less the verbosity of the unittest.TestCase-style. If I had my "druthers," they would magically be replaced by well-factored, readable tests using the pytest features.

@tseaver tseaver merged commit 6653800 into master May 26, 2024
60 checks passed
@tseaver tseaver deleted the tseaver-lint_squishing branch May 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting: 'tox.ini' is out of sync with GHA CI
2 participants