Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for passing blob directory path #16

Merged
merged 7 commits into from Apr 27, 2023
Merged

Add configuration option for passing blob directory path #16

merged 7 commits into from Apr 27, 2023

Conversation

FarooqAlaulddin
Copy link
Contributor

PL

To address #15.

 -b, --blobs        -- Directory for Blobs. By default, it will create
                       a blobs directory at <home>/var/blobs unless a 
                       path is provided -b path/to/blobs
  • argparse is used to handle argv.
  • -b, --blobs is optional.

Tests

3 new test units were added:

  • test_create_folders_and_files_w_blobs
  • test_zeo_conf_content_w_default_blobs
  • test_zeo_conf_content_w_specified_blobs

Other unit tests edited to reflect the change.

Test Status:

  • Ran 27 tests in 0.052s - OK image

@dataflake
Copy link
Member

Thank you for you contribution. We require all contributors to sign the Zope contributor agreement before we can merge the code, please see https://www.zope.dev/developer/becoming-a-committer.html

@FarooqAlaulddin
Copy link
Contributor Author

Thank you for you contribution. We require all contributors to sign the Zope contributor agreement before we can merge the code, please see https://www.zope.dev/developer/becoming-a-committer.html

Done.

@icemac
Copy link
Member

icemac commented Apr 24, 2023

@FarooqAlaulddin Could you please run the tests locally using tox -pauto?
There are some linting tests which fail and the code does not run on Python < 3.9.
(Sorry GitHub Actions was disabled, so the failures do not yet show up here. But for your next commit they will run again.)

Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment is removed this looks good, thank you.

src/zope/mkzeoinstance/tests/test_unix.py Outdated Show resolved Hide resolved
Remove test unit comment.
@FarooqAlaulddin
Copy link
Contributor Author

Great!

@dataflake
Copy link
Member

@FarooqAlaulddin Once a PR is ready for merging (all issues fixed, approvals given) the author can do the merge, so just go ahead and do so.

@FarooqAlaulddin FarooqAlaulddin merged commit dc79bed into zopefoundation:master Apr 27, 2023
7 checks passed
icemac added a commit that referenced this pull request Apr 28, 2023
@icemac
Copy link
Member

icemac commented Apr 28, 2023

Just released as https://pypi.org/project/zope.mkzeoinstance/5.1/.

@icemac
Copy link
Member

icemac commented May 3, 2023

This PR seems to cause plone/plone.recipe.zeoserver#45 (comment)

@petschki
Copy link
Contributor

petschki commented May 3, 2023

I've fixed that here #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants