Merge pull request #27 from cjwatson/traceback-reference-cycle

Avoid traceback reference cycle in PageTemplate._cook
zopefoundation · May 15, 2021 · 7153aa0 · 7153aa0
2 parents 6f01c12 + 034f713
commit 7153aa0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,7 +5,7 @@
 4.6.0 (unreleased)
 ==================
 
-- Nothing changed yet.
+- Avoid traceback reference cycle in ``PageTemplate._cook``.
 
 
 4.5.0 (2020-02-10)

diff --git a/src/zope/pagetemplate/pagetemplate.py b/src/zope/pagetemplate/pagetemplate.py
@@ -230,10 +230,13 @@ def _cook(self):
                 source_file, self._text, pt_engine, self.content_type)
         except:
             etype, e = sys.exc_info()[:2]
-            self._v_errors = [
-                "Compilation failed",
-                "%s.%s: %s" % (etype.__module__, etype.__name__, e)
-                ]
+            try:
+                self._v_errors = [
+                    "Compilation failed",
+                    "%s.%s: %s" % (etype.__module__, etype.__name__, e)
+                    ]
+            finally:
+                del e
 
         self._v_cooked = 1