Add comments per review [skip ci]

zopefoundation · Aug 14, 2018 · 5f6aab2 · 5f6aab2
1 parent 3daaadb
commit 5f6aab2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -2,7 +2,7 @@
  Changes
 =========
 
-4.5.1 (unreleased)
+4.6.0 (unreleased)
 ==================
 
 - Add support for Python 3.7.

diff --git a/src/zope/schema/_bootstrapinterfaces.py b/src/zope/schema/_bootstrapinterfaces.py
@@ -36,6 +36,8 @@ def doc(self):
         return self.__class__.__doc__
 
     def __lt__(self, other):
+        # There's no particular reason we choose to sort this way,
+        # it's just the way we used to do it with __cmp__.
         if not hasattr(other, 'args'):
             return True
         return self.args < other.args
@@ -45,6 +47,8 @@ def __eq__(self, other):
             return False
         return self.args == other.args
 
+    # XXX : This is probably inconsistent with __eq__, which is
+    # a violation of the language spec.
     __hash__ = zope.interface.Invalid.__hash__  # python3
 
     def __repr__(self):  # pragma: no cover

diff --git a/version.txt b/version.txt
@@ -1 +1 @@
-4.5.1.dev0
+4.6.0.dev0