Drop support for Python < 3.7 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
approved these changes
Dec 22, 2022
|
Thank you for (reviewing) this PR. 😃 |
|
Would anyone be willing to either release this to PyPI, or give me access so I can do it myself? |
|
Released! (I don't mind giving you PyPI access, but please mention your PyPI username in your request, as I'd hate to guess and get it wrong.) |
|
Colin on PyPI |
|
What Jürgen said. This would probably still be useful for future releases. (Thanks for doing 7.0.0.) |
cjwatson
added a commit
to cjwatson/zope.schema
that referenced
this pull request
Jan 2, 2023
I introduced this regression in zopefoundation#118 by misreading the try/except/else logic in `zope.schema._messageid`. The new tests should guard against somebody else making a similar mistake in future.
cjwatson
added a commit
to cjwatson/zope.schema
that referenced
this pull request
Jan 2, 2023
I introduced this regression in zopefoundation#118 by misreading the try/except/else logic in `zope.schema._messageid`. The new tests should guard against somebody else making a similar mistake in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zopefoundation/zope.testing#45 broke zope.schema's tests, so I guess it's time to do the corresponding removal here as well.