100% coverage for the managers.

zopefoundation · Aug 24, 2018 · 3920d0d · 3920d0d
1 parent 0b39928
commit 3920d0d
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/src/zope/securitypolicy/principalpermission.py b/src/zope/securitypolicy/principalpermission.py
@@ -112,7 +112,7 @@ def getPrincipalsAndPermissions(self):
 # simpler.
 try:
     from zope.testing.cleanup import addCleanUp
-except ImportError:
+except ImportError: # pragma: no cover
     pass
 else:
     addCleanUp(principalPermissionManager._clear)

diff --git a/src/zope/securitypolicy/principalrole.py b/src/zope/securitypolicy/principalrole.py
@@ -101,7 +101,7 @@ def getPrincipalsAndRoles(self):
 # simpler.
 try:
     from zope.testing.cleanup import addCleanUp
-except ImportError:
+except ImportError: # pragma: no cover
     pass
 else:
     addCleanUp(principalRoleManager._clear)

diff --git a/src/zope/securitypolicy/rolepermission.py b/src/zope/securitypolicy/rolepermission.py
@@ -104,7 +104,7 @@ def getRolesAndPermissions(self):
 # simpler.
 try:
     from zope.testing.cleanup import addCleanUp
-except ImportError:
+except ImportError: # pragma: no cover
     pass
 else:
     addCleanUp(rolePermissionManager._clear)

diff --git a/src/zope/securitypolicy/tests/test_rolepermissionmanager.py b/src/zope/securitypolicy/tests/test_rolepermissionmanager.py
@@ -57,6 +57,8 @@ def testRolePermission(self):
                          [(role, Allow)])
         self.assertEqual(manager.getPermissionsForRole(role),
                          [(permission, Allow)])
+        self.assertEqual(manager.getRolesAndPermissions(),
+                         [('APerm', 'ARole', Allow)])
 
     def testManyPermissionsOneRole(self):
         perm1 = definePermission('Perm One', 'P1').id

diff --git a/src/zope/securitypolicy/tests/test_settings.py b/src/zope/securitypolicy/tests/test_settings.py
@@ -27,3 +27,15 @@ def testPickleUnpickle(self):
             newAllow = pickle.loads(s)
 
             self.assertIs(newAllow, Allow)
+
+    def testDescription(self):
+        self.assertEqual("Explicit allow setting for permissions",
+                         Allow.getDescription())
+
+    def testName(self):
+        self.assertEqual("Allow",
+                         Allow.getName())
+
+    def testStr(self):
+        self.assertEqual("PermissionSetting: Allow",
+                         str(Allow))