Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Windows using Github actions? #32

Closed
jensens opened this issue Jul 30, 2020 · 5 comments
Closed

Run tests on Windows using Github actions? #32

jensens opened this issue Jul 30, 2020 · 5 comments

Comments

@jensens
Copy link
Member

jensens commented Jul 30, 2020

Since we have some windows specific parts in zope.sendmail: With Github actions it is relative easy to run tests on windows. Would it be an idea to add one (I can create this)? see also #30

@icemac
Copy link
Member

icemac commented Jul 31, 2020

I think you should be able to create a PR to try testing on Windows using GH Actions. However there is no blueprint for this in the zopefoundation repositories.

@mgedmin
Copy link
Member

mgedmin commented Aug 20, 2020

We've successfully used Appveyor in the past. I have zero experience with GH actions; a PR would be welcome, but if the important thing is to test on Windows, I could whip up a quick appveyor.yml.

@mgedmin
Copy link
Member

mgedmin commented Aug 20, 2020

Good thing I did: the error handling code is broken on Python 3 on Windows (exceptions are not subscriptable). Fix in #33, along with an appveyor.yml.

@jensens
Copy link
Member Author

jensens commented Aug 21, 2020

Thanks @mgedmin
I have no experience with nor an account at Appveyor. From our (Plone) experience it tends to be fragile, but I was not involved here, so it is what others told me. Anyway, I am w/o any emotions here as long as it tests the code.

If you're interested in an example how testing may look on Linux and Windows in one file with Github actions have a look at: https://github.com/plone/plone.recipe.zope2instance/blob/master/.github/workflows/testing.yml

One big advantage is, its all on one platform, Github. One big disadvantage is, its all on one platform, Github. ;-)

@icemac
Copy link
Member

icemac commented Sep 4, 2020

The package is now CI tested on windows so I am going to close this issue.

@icemac icemac closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants