Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on windows: pypiwin32 outdated fork is used. #30

Closed
jensens opened this issue Jul 30, 2020 · 1 comment
Closed

Fails on windows: pypiwin32 outdated fork is used. #30

jensens opened this issue Jul 30, 2020 · 1 comment
Labels

Comments

@jensens
Copy link
Member

jensens commented Jul 30, 2020

For some reason the windows related dependency pypiwin32 - an outdated fork of pywin32 - fails to install in Plone's buildout.coredev.

Installing instance.
While:
  Installing instance.
  Getting distribution for 'pypiwin32'.
Error: Picked: pypiwin32 = 223
Write to Town Square

It seems reason of the fork and its usage was a stalled project. It seems the pywin32 project is now maintained again. There are newer releases and commits.

I propose to use the main project again. We will try if usage of the main project release fixes our problem and in case it works we will prepare a PR.

cc @nilshofer

@jensens jensens added the bug label Jul 30, 2020
@jensens
Copy link
Member Author

jensens commented Jul 30, 2020

pywin32 fails with the same error. Reason is, it can not be installed by zc.buildout. If we install it before buildout using pip all works fine.

So yes, we should switch back to pywin32, this is a side effect of this findings. We will add it to with an environment marker to buildout.coredev like so:

pywin32; platform_system == "Windows"

So. we will prepare a PR, where we switch to pywin32 and additional add a section to https://github.com/zopefoundation/zope.sendmail/blob/master/docs/usage.rst with hints for installation on Windows.

jensens added a commit that referenced this issue Jul 30, 2020
jensens added a commit that referenced this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant