Update supported Pythons, 100% coverage #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the locale comparison functions always available, not just if that module had previously been imported before this module. That was a big footgun IMO.
…ning. Add trailing comma in install_requires.
icemac
approved these changes
Aug 13, 2018
| # py26,py27,pypy,coverage,docs | ||
| py26,py27,pypy,,py32,py33,coverage | ||
| envlist = | ||
| py27,pypy,py34,py35,py36,py37,coverage |
There was a problem hiding this comment.
Should docs be in this list, too?
There was a problem hiding this comment.
We don't seem to be very consistent about that...
It wasn't before, and there really are no actual docs or doctests, just the basic docstring.
|
Thanks! Would you like to make a PyPI release? Or I'd be happy to, given sufficient access ( |
|
Thanks, I've pushed 4.1.0 to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the locale comparison functions always available, not just if that module had previously been imported before this module. That was a big footgun IMO.
Fixes #1.