Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sorting of broken objects more gracefully. #4

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

viktordick
Copy link
Contributor

Repaired handling of broken objects (that can be compared but do not offer the required keys and can not be used in string functions like .lower() and strcoll()), which is used in the new ZMI.
Fixes: #3

@icemac icemac requested review from jamadden and icemac October 2, 2018 10:21
@icemac icemac added the bug label Oct 2, 2018
@icemac icemac added this to In progress in Zope 4 final release via automation Oct 2, 2018
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Additionally I'd like to have a change log entry.

Zope 4 final release automation moved this from In progress to Reviewer approved Oct 2, 2018
@viktordick viktordick merged commit 8e5e53c into master Oct 2, 2018
Zope 4 final release automation moved this from Reviewer approved to Done Oct 2, 2018
@viktordick viktordick deleted the re3-fix-smallest-sorting branch October 3, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants