Skip to content

Commit

Permalink
Do not use signature deprecated since SQLAlchemy 0.9. (#55)
Browse files Browse the repository at this point in the history
* Do not use signature deprecated since SQLAlchemy 0.9.

* Update CHANGES.rst

Co-authored-by: Marius Gedminas <marius@gedmin.as>

* Add changelog entry.

Co-authored-by: Michael Howitz <mh@gocept.com>
Co-authored-by: Marius Gedminas <marius@gedmin.as>
Co-authored-by: Thijs Damsma <tdamsma@gmail.com>
  • Loading branch information
4 people committed Apr 23, 2021
1 parent d9d6f9a commit 3e7b45c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Changes
``ZopeTransactionEvents``.
(`#46 <https://github.com/zopefoundation/zope.sqlalchemy/issues/46>`_)

- Reduce DeprecationWarnings with SQLAlchemy 1.4 and require at least
SQLAlchemy >= 0.9.
(`#54 <https://github.com/zopefoundation/zope.sqlalchemy/issues/54>`_)


1.3 (2020-02-17)
----------------
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

install_requires=[
'setuptools',
'SQLAlchemy>=0.7',
'SQLAlchemy>=0.9',
'transaction>=1.6.0',
'zope.interface>=3.6.0',
],
Expand Down
10 changes: 6 additions & 4 deletions src/zope/sqlalchemy/datamanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,13 @@ def after_attach(self, session, instance):
def after_flush(self, session, flush_context):
mark_changed(session, self.transaction_manager, self.keep_session)

def after_bulk_update(self, session, query, query_context, result):
mark_changed(session, self.transaction_manager, self.keep_session)
def after_bulk_update(self, update_context):
mark_changed(update_context.session,
self.transaction_manager, self.keep_session)

def after_bulk_delete(self, session, query, query_context, result):
mark_changed(session, self.transaction_manager, self.keep_session)
def after_bulk_delete(self, delete_context):
mark_changed(delete_context.session,
self.transaction_manager, self.keep_session)

def before_commit(self, session):
assert (
Expand Down

0 comments on commit 3e7b45c

Please sign in to comment.