-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SemVer for packaging (eg. 1.2 should have been 2.0) #36
Comments
"Drop support for Python 3.4..." dropped support for Python 3.4 - I know this as I reviewed the PR. I guess you meant the PR just before: #34 |
Indeed |
Well, the PR does not really have anything to do with the version picked during the release. Bumping major when a breaking change is part of a release is a recommended practice, but no big deal, we'll survive :) |
Should we re-release 1.2 as 2.0? |
And also we should add instructions for users about how they should adapt their code to the changelog, see #37. |
I don't it's necessary. Just let's consider it for the next breaking change!
Yes, that would definitely be helpful! |
As a re-release does not seem necessary, I am closing this issue as "won't fix". |
Version 1.2 was released with a number of breaking changes, breaking projects (eg. Kinto/kinto#2296)
(Drop support for Python 3.4, renamed the ZopeTransactionExtension class to ZopeTransactionEvents)
Would you mind following SemVer for following releases please?
The text was updated successfully, but these errors were encountered: