Restore raising of AttributeError when trying to set value of a read …

…only control.

CHANGES.rst

@@ -5,6 +5,9 @@ CHANGES
 5.2.2 (unreleased)
 ------------------
 
+- Restore raising of AttributeError when trying to set value of a
+  read only control.
+
 - Fix selecting radio and select control options by index
   (https://github.com/zopefoundation/zope.testbrowser/issues/31).
 

docs/narrative.rst

@@ -964,6 +964,27 @@ Hidden Control
     >>> ctrl.multiple
     False
 
+Read Only Control
+~~~~~~~~~~~~~~~~~
+
+.. doctest::
+
+    >>> ctrl = browser.getControl(name='readonly-value')
+    >>> ctrl
+    <Control name='readonly-value' type='text'>
+    >>> verifyObject(interfaces.IControl, ctrl)
+    True
+    >>> ctrl.value
+    'Read Only Text'
+    >>> ctrl.value = 'Overwrite'
+    Traceback (most recent call last):
+    ...
+    AttributeError: Trying to set value of readonly control
+    >>> ctrl.readonly
+    True
+    >>> ctrl.multiple
+    False
+
 Text Area Control
 ~~~~~~~~~~~~~~~~~
 

src/zope/testbrowser/browser.py

@@ -650,6 +650,10 @@ def __init__(self, control, form, elem, browser):
     def disabled(self):
         return 'disabled' in self._control.attrs
 
+    @property
+    def readonly(self):
+        return 'readonly' in self._control.attrs
+
     @property
     def type(self):
         typeattr = self._control.attrs.get('type', None)
@@ -695,6 +699,8 @@ def value(self):
     def value(self, value):
         if self._browser_counter != self.browser._counter:
             raise interfaces.ExpiredError
+        if self.readonly:
+            raise AttributeError("Trying to set value of readonly control")
         if self.type == 'file':
             self.add_file(value, content_type=None, filename=None)
         else:

src/zope/testbrowser/ftests/controls.html

@@ -11,6 +11,12 @@ <h1>Controls Tests</h1>
         <input type="text" name="text-value" id="text-value" value="Some Text" />
       </div>
 
+      <div>
+        <label for="text-value">Read Only Control</label>
+        <em>%(text-value)s</em>
+        <input type="text" name="readonly-value" id="readonly-value" readonly value="Read Only Text" />
+      </div>
+
       <div>
         <label for="password-value">Password Control</label>
         <em>%(password-value)s</em>