Skip to content

Commit

Permalink
Add explicit install_requires for BeautifulSoup4 and SoupSieve
Browse files Browse the repository at this point in the history
Since we import both, I think we should list them in install_requires.

I don't know if we should pin BeautifulSoup4 to >= 4.7.0, which is the
version where BeautifulSoup4 started depending on SoupSieve.  If we
don't, browser.getLink(id='foo.bar') might not work correctly?
  • Loading branch information
mgedmin committed Jun 26, 2019
1 parent 147583e commit 5dbd66e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions setup.py
Expand Up @@ -65,6 +65,8 @@
'zope.cachedescriptors',
'pytz > dev',
'WebTest >= 2.0.30',
'BeautifulSoup4', # do we need to require >= 4.7.0?
'SoupSieve >= 1.9.0',
'WSGIProxy2',
'six',
],
Expand Down

0 comments on commit 5dbd66e

Please sign in to comment.