Always convert an uploaded file to a string, don't pass files just be…

…cause they're real files.
zopefoundation · Feb 2, 2017 · ed6db88 · ed6db88
1 parent f6f605c
commit ed6db88
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -8,6 +8,8 @@ CHANGES
 - Fixed browser to only follow redirects for HTTP statuses
   301, 302, 303, and 307; not other 30x statuses such as 304.
 
+- Fix passing a real file to ``add_file``.
+
 
 5.1 (2017-01-31)
 ----------------

diff --git a/src/zope/testbrowser/browser.py b/src/zope/testbrowser/browser.py
@@ -698,7 +698,7 @@ def add_file(self, file, content_type, filename):
             raise TypeError("Can't call add_file on %s controls"
                             % self.mech_control.type)
 
-        if isinstance(file, io.IOBase):
+        if hasattr(file, 'read'):
             contents = file.read()
         else:
             contents = file